Issue
Read My Whole Code. It is working perfectly on every Phone except Marshmallow and Lollipop. In Marshmallow and Lollipop phones Only problem is coming in data.getData() returning null only in case of Picture Captured. It is working fine if i capture Video .I have 4 cases -
Choosing Picture from Gallery and show its thumbnail in
Imageview- Working Fine.Capturing Picture from Camera and show its thumbnail in
Imageview- NOT WORKING inMarshmallowandLollipop.Choosing Video from Gallery and show its thumbnail in
Imageview- Working Fine.3.Capturing Video from Camera and show its thumbnail in
Imageview- Working Fine.
Now There are many solutions but neither of them looks satisfactory,If code is working fine in case of Video Capturing then why its NOT working for Image Capturing?Is it a Bug or I am doing wrong somewhere?
Here is My Code . I have commented a line where crash happens-
@Override
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
super.onActivityResult(requestCode, resultCode, data);
int THUMBSIZE = 120;
switch (requestCode){
case RESULT_LOAD_IMAGE:
if (resultCode==RESULT_OK){
String column_Name= MediaStore.Images.Media.DATA;
String picturePath=getPath(column_Name,data.getData());
Bitmap orientedBitmap = ExifUtil.rotateBitmap(picturePath, BitmapFactory.decodeFile(picturePath));
Drawable fullpic=new BitmapDrawable(getResources(),ThumbnailUtils.extractThumbnail(orientedBitmap, THUMBSIZE, THUMBSIZE));
thumbnailview.setBackground(fullpic);
editText.setText(picturePath);
picker.setVisibility(View.VISIBLE);
thumbnailview.setClickable(false);
}
break;
case REQUEST_IMAGE_CAPTURE:
if (resultCode==RESULT_OK){
String picturePath="";
String column_Name=MediaStore.Images.Media.DATA;
picturePath=getPath(column_Name,data.getData());
//My app Crashes here because in Marshmallow data.getData() is always null.
Bitmap orientedBitmap = ExifUtil.rotateBitmap(picturePath, BitmapFactory.decodeFile(picturePath));
Drawable fullpic=new BitmapDrawable(getResources(),ThumbnailUtils.extractThumbnail(orientedBitmap, THUMBSIZE, THUMBSIZE));
thumbnailview.setBackground(fullpic);
editText.setText(picturePath);
picker.setVisibility(View.VISIBLE);
thumbnailview.setClickable(false);
}
break;
case RESULT_LOAD_VIDEO:
if (resultCode==RESULT_OK){
String column_Name=MediaStore.Video.Media.DATA;
String videoPath=getPath(column_Name,data.getData());
Drawable fullpic=new BitmapDrawable(getResources(),ThumbnailUtils.createVideoThumbnail(videoPath,MediaStore.Video.Thumbnails.MINI_KIND));
thumbnailview.setBackground(fullpic);
editText.setText(videoPath);
picker.setVisibility(View.VISIBLE);
thumbnailview.setClickable(false);
}
break;
case REQUEST_VIDEO_CAPTURE:
if (resultCode==RESULT_OK){
String column_Name=MediaStore.Video.Media.DATA;
String videoPath=getPath(column_Name,data.getData());
Drawable fullpic=new BitmapDrawable(getResources(),ThumbnailUtils.createVideoThumbnail(videoPath,MediaStore.Video.Thumbnails.MINI_KIND));
thumbnailview.setBackground(fullpic);
editText.setText(videoPath);
picker.setVisibility(View.VISIBLE);
thumbnailview.setClickable(false);
}
break;
}
if (picker != null) {
picker.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
OpenDialog();
}
});
}
}
private String getPath(String column_Name,Uri uri){
String[] projection = {column_Name};
String path = "";
Cursor cursor = getContentResolver().query(uri, projection, null, null, null);
int column_index_data ;
if (cursor != null) {
column_index_data = cursor.getColumnIndexOrThrow(column_Name);
cursor.moveToFirst();
path = cursor.getString(column_index_data);
cursor.close();
}
return path;
}
private void OpenDialog(){
dialogBox.setTitle("Select an Action");
dialogBox.setMessage("Choose Picture or Video");
dialogBox.setPositiveButton("Picture", new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
if (check_Permissions()){
OpenCameraDialog();
}
else {
request_Permissions();
CAMERA_DIALOG_PERMISSION=1;
}
}
});
dialogBox.setNegativeButton("Video", new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
if (check_Permissions()){
OpenVideoDialog();
}
else {
request_Permissions();
VIDEO_DIALOG_PERMISSION=1;
}
}
});
dialogBox.show();
}
private void OpenCameraDialog(){
dialogBox.setTitle("Select an Action");
dialogBox.setMessage("Choose Picture From");
dialogBox.setPositiveButton("Gallery", new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
final Intent galleryintent = new Intent(Intent.ACTION_PICK, android.provider.MediaStore.Images.Media.EXTERNAL_CONTENT_URI);
startActivityForResult(galleryintent, RESULT_LOAD_IMAGE);
}
});
dialogBox.setNegativeButton("Camera", new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
final Intent takePictureIntent = new Intent(MediaStore.ACTION_IMAGE_CAPTURE);
startActivityForResult(takePictureIntent, REQUEST_IMAGE_CAPTURE);
}
});
dialogBox.show();
}
private void OpenVideoDialog(){
dialogBox.setTitle("Select an Action");
dialogBox.setMessage("Choose Video From");
dialogBox.setPositiveButton("Gallery", new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
final Intent galleryintent = new Intent(Intent.ACTION_PICK, android.provider.MediaStore.Video.Media.EXTERNAL_CONTENT_URI);
startActivityForResult(galleryintent, RESULT_LOAD_VIDEO);
}
});
dialogBox.setNegativeButton("Camera", new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
final Intent takeVideoIntent = new Intent(MediaStore.ACTION_VIDEO_CAPTURE);
if (takeVideoIntent.resolveActivity(getPackageManager()) != null) {
startActivityForResult(takeVideoIntent, REQUEST_VIDEO_CAPTURE);
}
}
});
dialogBox.show();
}
private boolean check_Permissions(){
boolean GRANTED;
if (ContextCompat.checkSelfPermission(this, Manifest.permission.WRITE_EXTERNAL_STORAGE) +
ContextCompat.checkSelfPermission(this,Manifest.permission.READ_EXTERNAL_STORAGE) +
ContextCompat.checkSelfPermission(this,Manifest.permission.RECORD_AUDIO) +
ContextCompat.checkSelfPermission(this,Manifest.permission.CAMERA)!= PackageManager.PERMISSION_GRANTED){
GRANTED=false;
}
else {
GRANTED=true;
}
return GRANTED;
}
private void request_Permissions(){
ActivityCompat.requestPermissions(this,
new String[]{Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.READ_EXTERNAL_STORAGE,Manifest.permission.CAMERA,Manifest.permission.RECORD_AUDIO},
REQUEST_FOR_PERMISSION);
}
@Override
public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
super.onRequestPermissionsResult(requestCode, permissions, grantResults);
switch (requestCode){
case REQUEST_FOR_PERMISSION:
if ((grantResults.length>0)&& (grantResults[0] +grantResults[1]+grantResults[2]+grantResults[3]== PackageManager.PERMISSION_GRANTED)){
if (CAMERA_DIALOG_PERMISSION==1){
OpenCameraDialog();
CAMERA_DIALOG_PERMISSION=0;
}
else if (VIDEO_DIALOG_PERMISSION==1){
OpenVideoDialog();
VIDEO_DIALOG_PERMISSION=0;
}
}
else {
Toast.makeText(this, "Please GRANT Permissions", Toast.LENGTH_SHORT).show();
}
}
}
Solution
As,suggested by @CommonsWare -
Camera App do not need to return uri.
Also,
You need to tell Camera app where to write image.
So, i replaced my code with-
final Intent takePictureIntent = new Intent(MediaStore.ACTION_IMAGE_CAPTURE);
pictureUri=getOutputMediaFileUri(MEDIA_TYPE_IMAGE);
takePictureIntent.putExtra(MediaStore.EXTRA_OUTPUT,pictureUri);
startActivityForResult(takePictureIntent, REQUEST_IMAGE_CAPTURE);
and in onActivityResult -
case REQUEST_IMAGE_CAPTURE:
if (resultCode==RESULT_OK){
String picturePath="";
String column_Name= MediaStore.Images.Media.DATA;
if (data!=null){
if (data.getData()!=null){
picturePath=getPathfromUri(column_Name,data.getData());}
else {
picturePath= pictureUri.getPath();
}
}
else {
picturePath= pictureUri.getPath();
}}
Answered By - karanatwal.github.io
Answer Checked By - Katrina (JavaFixing Volunteer)
