[FIXED] save operation inside for loop

Issue

I am working in spring mvc + hibernate.....

I am making create operation inside for loop, but its executed only once. here is my sample code.

        String[] loanIds = request.getParameterValues("loanId");

loanIds value is 5

        for (String string : loanIds) {                 
            loanFinance.setFundingBankId(bankId);
            loanFinance.setIdFundsProductPurpose(Long.valueOf(68449));
            loanFinance.setLoanId(Long.parseLong(string));
            loanFinance.setLastModifiedBy(user.getId());
            loanFinance.setIdEntityloan(Long.parseLong(string));
            loanFinance.setAmount(10000.00);
            loanFinance.setStatus("A"); 

            commonRepository.save(loanFinance);     
            System.out.println("Saved Datas");
        }

I catalina.out I can see "Saved Datas" prints 5 times.... but table inserted only once.

Can anyone give me advice in this, what I am doing wrong here..

Solution

You are saving the same object over and over. If you want to insert 5 different element you need to create a new element at each iteration.

 for (String string : loanIds) {  
        loanFinance = new LoanFinance();               
        loanFinance.setFundingBankId(bankId);
        loanFinance.setIdFundsProductPurpose(Long.valueOf(68449));
        loanFinance.setLoanId(Long.parseLong(string));
        loanFinance.setLastModifiedBy(user.getId());
        loanFinance.setIdEntityloan(Long.parseLong(string));
        loanFinance.setAmount(10000.00);
        loanFinance.setStatus("A"); 

        commonRepository.save(loanFinance);     
        System.out.println("Saved Datas");
    }

Answered By - Giovanni
Answer Checked By - Timothy Miller (JavaFixing Admin)