[FIXED] Why iterate last data from ArrayList<>?

Issue

I get data from database perfectly and pass to the Thymeleaf(Template), but the problem is near mdl.addAttribute("number" ,request.getNumber()) in controller to detect last value from foreach loop iteration and send by model

Here down my code:

Dto

public interface ProfileDto {
    public Integer getU_id();
    public Integer getP_id();
    public String getEmail();
    public String getUsername();
    public String getPassword();
    public String getContact();
    public String getDate();
    public String getProfile();
    public String getWebsite();
    public String getBio();
    public String getGender();
    public String getPost();
}

Entity

@Entity
@Table(name = "request_master")
public class Request {
    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    private int req_id;
    private int sender_id;
    private int receiver_id;
    private String status;
    private String date;
    @Transient
    private int number;
    // getter setter

}

Repository

public interface profileRepo extends JpaRepository<Request, Integer> {
    @Query(nativeQuery = true, value = "SELECT * FROM registration_master rm INNER JOIN profile_master pm ON rm.u_id = pm.user_id WHERE rm.u_id != ?")
    List<ProfileDto> findByIdUser(Integer Id);

public interface requestRepo extends JpaRepository<Request, Integer> {
    @Query(nativeQuery = true,  value="SELECT * FROM request_master WHERE sender_id = ? and receiver_id = ?")
    List<Request> getSuggetionButton(Integer Sender_id, Integer Receiver_id);
}

Service

@Service
public class ServiceImpl implements Service {
    @Autowired
    private profileRepo profileRepo;

    @Autowired
    private requestRepo requestRepo;

    @Override
    public List<ProfileDto> getSuggestedList(Integer Id) {
        return this.profileRepo.findByIdUser(Id);
    }

    @Override
    public List<Request> getSuggestionButton(Integer Sender_id, Integer Receiver_id) {
        return this.requestRepo.getSuggetionButton(Sender_id, Receiver_id);
    }

}

Controller

@Controller
public class Controller {
    @Autowired
    private Service service;
    @RequestMapping(value = "/", method = RequestMethod.GET)
    public String home(Model mdl, Request request) {
        int SessionId = Integer.parseInt(session.getAttribute("uid").toString());
        List<ProfileDto> Suggestion_list = service.getSuggestedList(SessionId);
        for(ProfileDto Suggestion_id : Suggestion_list)
        {
            List<Request> Friend_request = this.service.getSuggestionButton(SessionId, Suggestion_id.getU_id());
            if(Friend_request.size() > 0)
            {
                request.setNumber(Friend_request.size());
            }
            else
            {
                request.setNumber(0);
            }
        }
        mdl.addAttribute("number" ,request.getNumber());
        mdl.addAttribute("suggestionList", Suggestion_list);
        return "post";
        
    }
}

Thymeleaf

<div class="follow-user-list" th:each="suggetionFriend : ${suggestionList}">
    <div class="follow-user clearfix" th:id="'follow-user'+${suggetionFriend.u_id}">
        <img th:src="${suggetionFriend.profile}" alt="" class="profile-photo-sm pull-left" />
        <div class="name clearfix">
            <h5>
                <a href="#" class="follow-name" th:text="${suggetionFriend.username}"></a>
            </h5>
            <div class='follow-unfollow-btn' th:id="'follow-unfollow-button'+${suggetionFriend.u_id}">
                <div th:text="${number}">
                                
                </div>
            </div>
        </div>
    </div>
</div>

in below image 1 is for condition matched and find data and 0 is for condition not matched and not find data

In My output i can get only last iterate data in both user

Output:

Expected output:

I think problem is to pass data from controller to thymeleaf

If you have good idea to transfer value from Controller to Template tell me please

Solution

You should maintain request for each profile/user instead of having single request, what I mean by that is you should have number of request for each profileId/userId, you can maintain a map of profileId/userId and number of request for that profile/user, and use that map in your template, try to modify your code as below

Controller

@Controller
public class Controller {
    @Autowired
    private Service service;
    @RequestMapping(value = "/", method = RequestMethod.GET)
    public String home(Model mdl, Request request) {
        Map<Integer, Integer> profileToNoOfRequestMap = new HashMap<>();
        int SessionId = Integer.parseInt(session.getAttribute("uid").toString());
        List<ProfileDto> Suggestion_list = service.getSuggestedList(SessionId);
        for(ProfileDto Suggestion_id : Suggestion_list)
        {
            List<Request> Friend_request = this.service.getSuggestionButton(SessionId, Suggestion_id.getU_id());

            profileToNoOfRequestMap.put(Suggestion_id.getU_id(), Friend_request.size());
        }
        mdl.addAttribute("profileToNoOfRequestMap", profileToNoOfRequestMap);
        mdl.addAttribute("suggestionList", Suggestion_list);
        return "post";
        
    }
}

Thymeleaf

<div class="follow-user-list" th:each="suggetionFriend : ${suggestionList}">
    <div class="follow-user clearfix" th:id="'follow-user'+${suggetionFriend.u_id}">
        <img th:src="${suggetionFriend.profile}" alt="" class="profile-photo-sm pull-left" />
        <div class="name clearfix">
            <h5>
                <a href="#" class="follow-name" th:text="${suggetionFriend.username}"></a>
            </h5>
            <div class='follow-unfollow-btn' th:id="'follow-unfollow-button'+${suggetionFriend.u_id}">
                <div th:text="${profileToNoOfRequestMap.get(suggetionFriend.u_id)}">
                                
                </div>
            </div>
        </div>
    </div>
</div>

Answered By - Chintan Radia
Answer Checked By - Terry (JavaFixing Volunteer)