[FIXED] The code showing Time Limit Exceed erroe, could some one explain, where is problem in this code

Issue

LeetCode 485 Given a binary array nums, return the maximum number of consecutive 1's in the array.

Example 1:

Input: nums = [1,1,0,1,1,1] Output: 3 Explanation: The first two digits or the last three digits are consecutive 1s. The maximum number of consecutive 1s is 3.

---------Solution:-------

public int findMaxConsecutiveOnes(int[] nums) {
    int maxConsSize = Integer.MIN_VALUE;
    
    int i = -1, j=-1, k=0;
    
    while(k<nums.length){
        while(k<nums.length && nums[k] == 1){
            k++;
            i++;
        }
        
        if(nums[k] == 0){
            maxConsSize = Math.max(maxConsSize,i-j);
            j = i;
        }
        
    }
    
    maxConsSize = Math.max(maxConsSize,i-j);
    
    return maxConsSize;
}

Solution

You have an infinity loop. Try run this:

public class Test {
    public static void main(String[] args) {
        int maxConsSize = Integer.MIN_VALUE;
        int[] nums = {1,1,0,1,1,1};

        int i = -1, j=-1, k=0;
        System.out.println(nums.length);

        while(k<nums.length){
            while(k<nums.length && nums[k] == 1){
                k++;
                i++;
                System.out.println("k = " + k);
            }

            if(nums[k] == 0){
                maxConsSize = Math.max(maxConsSize,i-j);
                j = i;
            }

        }

        maxConsSize = Math.max(maxConsSize,i-j);

        System.out.println(maxConsSize);
    }
}

Output:

6
k = 1
k = 2

After reading the first 0 you are in infinite loop. You have made this task very complicated :)

It's probably not the best solution, but it should be faster

public int findMaxConsecutiveOnes(int[] nums) {
    int maxCons = 0;
    int currentCons = 0;
    for (int i = 0; i < nums.length; i++) {
        if (nums[i] == 0) {
           if (currentCons > maxCons) {
              maxCons = currentCons;
           }
              currentCons = 0;
           } else {
              currentCons++;
           }
        }

        if (currentCons > maxCons) {
            maxCons = currentCons;
        }
        
        return maxCons;
    }
}

Answered By - aagaa
Answer Checked By - David Marino (JavaFixing Volunteer)