[FIXED] Redirect the page according to the user role after validating user

Issue

I have been trying to redirect the user that has logged into the system to their respective page after checking their email and password. But i am not sure about the logic behind that coding and when i try it it just response with the else statement. I have tried the validation of the email and password and that works fine and redirects to the correct page, but when i add the user type condition it doesnt work

I have tried including nested if statements, but i am not sure about its logic,it always executes the else statement.

loginControllerServlet.java

protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {


        String email=request.getParameter("email");
        String password=request.getParameter("pwrd");

        User theUser=loginDbUtil.gettype(email);

        if(loginDbUtil.check(email, password))
        {       
            String p="pharmacist";

            if(theUser.getType()==p)
            {
//              HttpSession session=request.getSession();
//                  session.setAttribute("email", email);
                    response.sendRedirect("medicine.jsp");
            }
            else
            {
                response.sendRedirect("index.jsp");
            }




    }else
    {
        response.sendRedirect("index.jsp");
    }

    }
}

loginDbUtil.java

public boolean check(String email,String password)
    {
        Connection myConn=null;
        PreparedStatement myStmt=null;
        ResultSet rs=null;

        try
        {
            //get db connection
            myConn=dataSource.getConnection();


            //sql statemtn
            String sql="select email,pass from usertab where email=? and pass=? ";


            myStmt=myConn.prepareStatement(sql);

            //set the param values for user
            myStmt.setString(1, email);
            myStmt.setString(2, password);

            rs=myStmt.executeQuery();

            if(rs.next())
            {
                return true;  
            }



        }catch(Exception e)
        {
            e.printStackTrace();
        }



        return false;
    }




    public User gettype(String email) {

        User type=null;

        Connection myConn=null;
        PreparedStatement myStmt=null;
        ResultSet rs=null;

        try
        {
            //get db connection
            myConn=dataSource.getConnection();


            //sql statemtn
            String sql="select type from usertab where email=?  ";


            myStmt=myConn.prepareStatement(sql);

            //set the param values for user
            myStmt.setString(1, email);

            rs=myStmt.executeQuery();

            if(rs.next())
            {
                String t=rs.getString("type");



            type =new User(t);

            }



        }catch(Exception e)
        {
            e.printStackTrace();
        }

        return type;

    }

}

What i want is after the email and password is checked then next check for the users data type and redirect them to the correct page

Solution

In your loginControllerServlet.java change this to

if(theUser.getType()==p)

to this

if(theUser.getType().equals(p))

Answered By - ErShakirAnsari