[FIXED] If else not working on the basis of user selection

Issue

I am working on HTML tables. For that I am returning JSON from my Java code. I have a UI as HTML page where there is a form having from date to date and a select tag having 4 options like this

 <form id="formId" method="get">
        <div class="container">
            <h4>Start Date:</h4>
            <input type="text" id="startdate" name="fromdate" width="276"
                placeholder="dd/mm/yyyy" required />

            <h4>End Date:</h4>
            <input type="text" id="enddate" name="todate" width="276"
                placeholder="dd/mm/yyyy" required />


            <h4>Outlets:</h4>
            <select name="outlet" id="all">
                <option>ALL</option>
                <c:forEach var="item" items="${obj.outlet}">
                    <option>${item}</option>
                </c:forEach>
            </select>

            <br>

            <br>
            <div>

                <button id="button" class="btn btn-default" type="submit">Search</button>
            </div>

        </div>
</form>

I am taking that input from the form and getting values in the servlet in doget method like below:

    String fromdate=request.getParameter("fromdate");
        String todate=request.getParameter("todate");
        String outlet=request.getParameter("outlet");

//      System.out.println(String.format("fromdate: %s, todate: %s, outlet: %s", new Object[]{fromdate, todate, outlet}));
        List<String> outletList = Arrays.asList(outlet.split("\\s*,\\s*"));
        try {
            String json = HourlySalesDateOutlet.createJson(outletList, fromdate, todate);
            response.getWriter().write(json);
//          System.out.println("dheeraj"+json);
        }
        catch (Exception e) {

            e.printStackTrace();
        }


    }

Now here is my Java class where I have written two queries one for if the user selects all and other if user select specific outlet. My problem is the if statement is not executing only else is executing if the user selects one outlet from FORM if the user selects ALL then it's not working.

Below is my code:

   public static String createJson(List<String> outletList, String startDate, String endDate) throws Exception {
        Connection con = null;
        String query1;
        List<Map<String, String>> mapList = new LinkedList<Map<String, String>>();
        String outletStr = outletList.stream().collect(Collectors.joining("','", "('", "')"));
        if (outletList.equals("ALL")) {
            query1 = "SELECT a.OUTLET,b.CUSTOMERDESCRIPTOR,a.BILLDATE,HOUR(a.BILLTIME) AS HOURS, SUM(a.NETAMOUNT) AS AMOUNT FROM SYNCBILL a,ecustomer b WHERE a.OUTLET=b.CUSTOMERIDENTIFIER AND a.CANCELLED<>'Y' AND a.BILLDATE BETWEEN STR_TO_DATE(REPLACE('"
                    + startDate + "','/','.'),GET_FORMAT(DATE,'EUR')) AND STR_TO_DATE(REPLACE('" + endDate
                    + "','/','.'),GET_FORMAT(DATE,'EUR')) GROUP BY OUTLET,BILLDATE,HOUR(BILLTIME)";
            System.out.println("all"+query1);

        } else {

            query1 = "SELECT a.OUTLET,b.CUSTOMERDESCRIPTOR,a.BILLDATE,HOUR(a.BILLTIME) AS HOURS, SUM(a.NETAMOUNT) AS AMOUNT FROM SYNCBILL a,ecustomer b WHERE a.OUTLET=b.CUSTOMERIDENTIFIER AND b.CUSTOMERDESCRIPTOR in "
                    + outletStr + " AND a.CANCELLED<>'Y' AND a.BILLDATE BETWEEN STR_TO_DATE(REPLACE('" + startDate
                    + "','/','.'),GET_FORMAT(DATE,'EUR')) AND STR_TO_DATE(REPLACE('" + endDate
                    + "','/','.'),GET_FORMAT(DATE,'EUR')) GROUP BY OUTLET,BILLDATE,HOUR(BILLTIME)";
            System.out.println("2"+query1);
        }

        try {


            con = DBConnection.createConnection();


            PreparedStatement ps = con.prepareStatement(query1);
            ResultSet rs = ps.executeQuery();
            Map<RecordKey, Long> mapData = getMapList(rs);
        }

I am not posting the full Java code. What I want is if the user selects all then if statement should execute and the query in it should execute. If the user selects else, then other should work, and here in my code only else is working if is not executing.

How can I debug this?

Solution

I have a simple solution for your problem. When user selects all, then in that case pass the empty list and while making the query just put this condition.

if (outletList.size()==0) {
// case for all
} else {
// do regular stuff
}

Answered By - Pushpesh Kumar Rajwanshi