[FIXED] How to include currency symbol for the converted currencies?

Issue

I tried to update the Java currency converter application in the following link. This is the code

   import static javax.swing.JFrame.EXIT_ON_CLOSE;

    public class Main extends JPanel {

    enum Currency {

    USD("United States Dollar"),
    GBR("Great Britain Pound"),
    AUD("Australian Dollar"),
    EUR("Euro");

    private String description;
    Currency(String description) {

        this.description = description;

    }

    @Override public String toString() {
        return this.name() + " - " + this.description;

    }
}
class CurrencyPair {

    private final Currency from;
    private final Currency to;

    public CurrencyPair(Currency from, Currency to) {
        this.from = from;
        this.to = to;
    }

    @Override public boolean equals(Object o) {
        if (this == o) return true;
        if (o == null || getClass() != o.getClass()) return false;

        CurrencyPair that = (CurrencyPair) o;
        if (from != that.from) return false;
        return to == that.to;
    }

    @Override public int hashCode() {
        int result = from.hashCode();
        result = 31 * result + to.hashCode();
        return result;
    }
}

private final Map<CurrencyPair, BigDecimal> exchangeRates = new HashMap<CurrencyPair, BigDecimal>() {{
    put(new CurrencyPair(Main.Currency.USD, Main.Currency.USD), BigDecimal.valueOf(1));
    put(new CurrencyPair(Main.Currency.AUD, Main.Currency.AUD), BigDecimal.valueOf(1));
    put(new CurrencyPair(Main.Currency.EUR, Main.Currency.EUR), BigDecimal.valueOf(1));
    put(new CurrencyPair(Main.Currency.GBR, Main.Currency.GBR), BigDecimal.valueOf(1));

    put(new CurrencyPair(Main.Currency.USD, Main.Currency.GBR), BigDecimal.valueOf(0.75));
    put(new CurrencyPair(Main.Currency.USD, Main.Currency.AUD), BigDecimal.valueOf(1.33));
    put(new CurrencyPair(Main.Currency.USD, Main.Currency.EUR), BigDecimal.valueOf(0.89));

    put(new CurrencyPair(Main.Currency.EUR, Main.Currency.USD), BigDecimal.valueOf(1.12));
    put(new CurrencyPair(Main.Currency.EUR, Main.Currency.AUD), BigDecimal.valueOf(1.49));
    put(new CurrencyPair(Main.Currency.EUR, Main.Currency.GBR), BigDecimal.valueOf(0.85));

    put(new CurrencyPair(Main.Currency.AUD, Main.Currency.USD), BigDecimal.valueOf(0.74));
    put(new CurrencyPair(Main.Currency.AUD, Main.Currency.EUR), BigDecimal.valueOf(0.67));
    put(new CurrencyPair(Main.Currency.AUD, Main.Currency.GBR), BigDecimal.valueOf(0.57));

    put(new CurrencyPair(Main.Currency.GBR, Main.Currency.USD), BigDecimal.valueOf(1.33));
    put(new CurrencyPair(Main.Currency.GBR, Main.Currency.EUR), BigDecimal.valueOf(1.18));
    put(new CurrencyPair(Main.Currency.GBR, Main.Currency.AUD), BigDecimal.valueOf(1.76));

}};

public Main() {
    super(new FlowLayout(FlowLayout.LEADING));

    // Amount
    JTextField amountInput = new JTextField(20);
    JPanel amount = new JPanel();
    amount.add(amountInput);
    amount.setBorder(BorderFactory.createTitledBorder("Enter Amount"));
    add(amount, BorderLayout.CENTER);

    // From
    JPanel from = new JPanel();
    JComboBox fromOptions = new JComboBox(Currency.values());
    from.add(fromOptions);
    from.setBorder(BorderFactory.createTitledBorder("Select currency"));
    add(from, BorderLayout.CENTER);

    // To
    JComboBox toOptions = new JComboBox(Currency.values());
    JPanel to = new JPanel();
    to.add(toOptions);
    to.setBorder(BorderFactory.createTitledBorder("Convert to"));
    add(to, BorderLayout.CENTER);

    // Convert Action
    JLabel convertText = new JLabel();
    JButton convertCmd = new JButton("Convert");
    convertCmd.addActionListener(convertAction(amountInput, fromOptions, toOptions, convertText));
    JPanel convert = new JPanel();
    convert.add(convertCmd);
    convert.add(convertText);
    add(convert);
}

private ActionListener convertAction(
        final JTextField amountInput,
        final JComboBox fromOptions,
        final JComboBox toOptions,
        final JLabel convertText) {

    return new ActionListener() {
        public void actionPerformed(ActionEvent e) {
            // TODO: Needs proper validation
            String amountInputText = amountInput.getText();
            if ("".equals(amountInputText)) { return; }

            // Convert
            BigDecimal conversion = convertCurrency(amountInputText);
            convertText.setText(NumberFormat
                    .getCurrencyInstance(Locale.US)
                    .format(conversion));
        }

        private BigDecimal convertCurrency(String amountInputText) {
            // TODO: Needs proper rounding and precision setting
            CurrencyPair currencyPair = new CurrencyPair(
                    (Currency) fromOptions.getSelectedItem(),
                    (Currency) toOptions.getSelectedItem());
            BigDecimal rate = exchangeRates.get(currencyPair);
            BigDecimal amount = new BigDecimal(amountInputText);
            return amount.multiply(rate);
        }
    };
}


public static void main(String[] args) {
    JFrame frame = new JFrame();
    frame.getContentPane().add(new Main());
    frame.setTitle("Currency Thing");
    frame.setSize(500, 500);
    frame.setDefaultCloseOperation(EXIT_ON_CLOSE);
    frame.setLocationRelativeTo(null);
    frame.setVisible(true);
}
}

The main issue is .getCurrencyInstance(Locale.US). The USD currency symbol appears to all converted results even they are different than USD.

I tried to create the if clauses to the currency pairs e.g if(new CurrencyPair(Currency.USD, Currency.USD)) but it is not a good code line.

I want to implement a solution that any converted result to have their own currency.

Solution

How about:

enum Currency {

    USD("United States Dollar", Locale.US),
    GBP("Great Britain Pound", Locale.UK),
    AUD("Australian Dollar", new Locale("en", "AUS")),
    EUR("Euro", /*here little complicated*/ Locale.FRANCE);

    private final Locale locale;
    private final String description;

    Currency(String description, Locale locale) {
        this.description = description;
        this.locale = locale;
    }
 
    @Override public String toString() {
        return this.name() + " - " + this.description;
    }
    //... getters
}

..extending Currency by a "locale" field. (alternatively String currency;)

And then fetch&use it:

 // Convert
 BigDecimal conversion = convertCurrency(amountInputText);
 // fetch (to) locale
 Locale locale = ((Currency) toOptions.getSelectedItem()).getLocale();
 // ... & apply
 convertText.setText(NumberFormat
                .getCurrencyInstance(locale)
                .format(conversion));

One (little) problem I see with this solution/formatting, that in the mentioned countries number format are not consistent. (thousands/decimal separator will change with applied locale)

EDIT:

..and even worse/uglier: some of the countries pre-pend their currency symbol others ap-pend.

---

better approach:

1. With Currency.symbol:

   enum Currency {
   
     USD("United States Dollar", "$"),
     GBP("Great Britain Pound", "£"),
     AUD("Australian Dollar", "AUD"),
     EUR("Euro", "€");
   
     private final String symbol;
    ...
   

2. Introduce (static) EnumMap of <Currency, DecimalFormat> and pre-fill it:

   private static final Map<Currency, DecimalFormat> SYMBOL2FMT
       = new EnumMap<>(Currency.class) {{
       for (Currency c : Currency.values()) {
           put(c, new DecimalFormat("###,###.### " + c.getSymbol()));
       }
   }};
   

3. bind it together:

    // Convert ...
    BigDecimal conversion = convertCurrency(amountInputText);
    // fetch (to) symbol
    Currency toCurrency = ((Currency) toOptions.getSelectedItem());
    convertText.setText(SYMBOL2FMT.get(toCurrency).format(conversion));
   

Answered By - xerx593