[FIXED] Loop: This method must return a result of type boolean

Issue

This is the error I get:

This method must return a result of type boolean

And this is the code:

public boolean seleccionar(Aeronave otra) {
    for (int i = 0; i < this.as.length; i++) {
        if (otra != null && !otra.equals(this.as[i]) && otra.amenazadaPor(this.as[i])) {
            return true;
        } else {
            return false;
        }
    }
}

Solution

The issue is that it is possible that the for-loop will loop through all elements and eventually reach the end and no result is returned. In this case we return false to ensure this.

public boolean seleccionar (Aeronave otra) {
    for (int i=0; i < this.as.length; i++) {
        if (otra !=null && !otra.equals(this.as[i]) && otra.amenazadaPor(this.as[i])) {
            return true;
        }
    }
    return false;
}

Answered By - Jason